nevi-me commented on a change in pull request #8608:
URL: https://github.com/apache/arrow/pull/8608#discussion_r519169297
##########
File path: rust/arrow/src/ipc/convert.rs
##########
@@ -537,59 +529,62 @@ pub(crate) fn get_fb_field_type<'a: 'b, 'b>(
}
}
List(ref list_type) => {
- let inner_types = get_fb_field_type(list_type, fbb);
- let child = ipc::Field::create(
- fbb,
- &ipc::FieldArgs {
- name: None,
- nullable: false,
- type_type: inner_types.type_type,
- type_: Some(inner_types.type_),
- children: inner_types.children,
- dictionary: None,
- custom_metadata: None,
- },
- );
+ let child = build_field(fbb, list_type);
+ // let inner_types = get_fb_field_type(list_type, fbb);
Review comment:
Forgot about it(them), I was struggling with compiling due to lifetime
issues, so I commented out those lines in case I needed to revert them. I've
now removed them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
