joosthooz commented on PR #33738:
URL: https://github.com/apache/arrow/pull/33738#issuecomment-1396819003

   Nice, I think the WriteAndCheckBackpressure span is important because that's 
where the backpressure is checked and also it performs some work combining 
staged batches (in `PopStagedBatch`). Maybe that even deserves its own span 
because it is not always called (only if enough rows have arrived in the `Push` 
function).
   Shouldn't there also be a span created in the delta that gets submitted to 
the IO executor in `WriteNext`? That's where the actual writing (and parquet 
encoding & compression) is being performed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to