tustvold commented on code in PR #3574:
URL: https://github.com/apache/arrow-rs/pull/3574#discussion_r1082903996
##########
parquet/src/errors.rs:
##########
@@ -17,12 +17,13 @@
//! Common Parquet errors and macros.
+use std::error::Error;
use std::{cell, io, result, str};
#[cfg(feature = "arrow")]
use arrow_schema::ArrowError;
-#[derive(Debug, PartialEq, Clone, Eq)]
Review Comment:
That we don't actually provide a meaningful PartialEq implementation for a
large portion of the errors we produce, I dunno it feels like a strange thing
for an error to provide... I've double-checked that DataFusion doesn't provide
something similar, neither do any of the other crates in this repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
