rok commented on PR #33810: URL: https://github.com/apache/arrow/pull/33810#issuecomment-1399101391
> This is my first Arrow PR. I am very open to any feedback or suggestions you might have! Welcome @danepitkin! Thanks for opening the PR! > I followed the instructions as stated in the original GH issue, but there is now some redundancy between `Table.drop(<str or list(str)>)`, `Table.drop_column(<str>)`, and `Table.remove_column(<index>)`. In my opinion, it would have been nicer to consolidate these from the start. However, since backwards compatibility is important, would you say this PR is the right approach? I would slightly prefer `Table.drop_column(<str or list(str)>)` over `Table.drop_column(<str>)` and `Table.drop(<list(str)>)`. I don't know if `.drop` -> `.drop_column` makes sense at this point. [Pandas uses `.drop` for everything](https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.drop.html) but it does index dropping as well. Perhaps you could just alias the two and introduce a deprecation warning? (e.g. [here](https://github.com/apache/arrow/blob/a16c54567ada6729311fd26bdbee4b5e61901410/python/pyarrow/plasma.py#L118)). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
