zeroshade commented on code in PR #387:
URL: https://github.com/apache/arrow-adbc/pull/387#discussion_r1087085635
##########
go/adbc/driver/flightsql/flightsql_adbc.go:
##########
@@ -324,7 +345,19 @@ func doGet(ctx context.Context, cl *flightsql.Client,
endpoint *flight.FlightEnd
}
func (c *cnxn) SetOption(key, value string) error {
+ if strings.HasPrefix(key, OptionRPCCallHeaderPrefix) {
+ name := strings.TrimPrefix(key, OptionRPCCallHeaderPrefix)
+ if value == "" {
+ c.hdrs.Delete(name)
+ } else {
+ c.hdrs.Append(name, value)
+ }
+ return nil
+ }
+
switch key {
+ case OptionAuthorizationHeader:
Review Comment:
hmm, it's hard to say. There is the possibility that you may want to replace
the authorization header? But i can't think of a good reason to do that over
just making a new connection. I guess we should remove this from the connection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
