maartenbreddels commented on a change in pull request #8628:
URL: https://github.com/apache/arrow/pull/8628#discussion_r520776198
##########
File path: python/pyarrow/tests/test_compute.py
##########
@@ -860,6 +860,17 @@ def test_fill_null():
expected = pa.array([None, None, None, None])
assert result.equals(expected)
+ arr = pa.array(['a', 'bb', None])
+ result = arr.fill_null('ccc')
+ expected = pa.array(['a', 'bb', 'ccc'])
+ assert result.equals(expected)
+
+ arr = pa.array([b'a', b'bb', None], type=pa.large_binary())
+ result = arr.fill_null('ccc')
+ expected = pa.array([b'a', b'bb', b'ccc'])
Review comment:
Thanks, I stared at that piece of code for quite a bit!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
