paleolimbot commented on PR #365: URL: https://github.com/apache/arrow-adbc/pull/365#issuecomment-1404476464
> I'll admit my grasp of R is nearly nonexistent, so I trust what you're doing here. I will try to solicit reviews for this side of things. The main design choice that might be controversial is my use of R's C API rather than cpp11 or Rcpp (a bit like bulding a Python C extension without Cython). Both cpp11 and Rcpp have some of the C types <-> R types conversion that I built from scratch here (int, std::string, etc.) and some helpers for external pointers; however, I don't think using either of them would result in any earth-shattering maintainability improvements. The main thing to get used to is that all `R_**()` and `Rf_**() calls could `longjmp` if there is error. Other than that, I tried hard to be very literal when mapping R to ADBC: this package doesn't provide anything R users would recognize as idiomatic (those packages can/should live elsewhere). Hopefully that will help make driver tests written using this package recognizable/reviewable by you/the ADBC community (and not just low-level R programmers, whose reviews might be harder to come by). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
