[GitHub] [arrow] alamb commented on a change in pull request #8639: ARROW-10559: [Rust][DataFusion] Split up logical_plan/mod.rs into sub modules

[GitBox]

alamb commented on a change in pull request #8639:
URL: https://github.com/apache/arrow/pull/8639#discussion_r521484903



##########
File path: rust/datafusion/src/logical_plan/mod.rs
##########
@@ -1264,31 +1050,6 @@ mod tests {
         Ok(())
     }
 
-    #[test]
-    fn test_visitor() {
-        let schema = Schema::new(vec![]);
-        assert_eq!("[]", format!("{}", display_schema(&schema)));
-    }
-
-    #[test]
-    fn test_display_empty_schema() {
-        let schema = Schema::new(vec![]);
-        assert_eq!("[]", format!("{}", display_schema(&schema)));
-    }
-
-    #[test]
-    fn test_display_schema() {
-        let schema = Schema::new(vec![
-            Field::new("id", DataType::Int32, false),
-            Field::new("first_name", DataType::Utf8, true),
-        ]);
-
-        assert_eq!(
-            "[id:Int32, first_name:Utf8;N]",
-            format!("{}", display_schema(&schema))
-        );
-    }

Review comment:
       Good 👁️ 
   
   I removed 
   ```
       fn test_visitor() {
           let schema = Schema::new(vec![]);
           assert_eq!("[]", format!("{}", display_schema(&schema)));
       }
   ```
   
   Which is redundant, except for the name, with the test immediately below: 
   ```
       #[test]
       fn test_display_empty_schema() {
           let schema = Schema::new(vec![]);
           assert_eq!("[]", format!("{}", display_schema(&schema)));
       }
   ```
   
   Aka it was removing a copy / paste bug (that I added 😞 )




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org