kiszk commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r521499370
##########
File path: cpp/src/arrow/ipc/reader.cc
##########
@@ -107,6 +108,23 @@ Status InvalidMessageType(MessageType expected,
MessageType actual) {
// ----------------------------------------------------------------------
// Record batch read path
+/// \brief Structure to keep common arguments to be passed
+struct IpcReadContext {
+ IpcReadContext(DictionaryMemo* memo, const IpcReadOptions& option,
DictionaryKind* kind,
+ bool swap)
+ : dictionary_memo(memo), options(option), kind(kind), swap_endian(swap)
{}
+
+ DictionaryMemo* dictionary_memo;
+
+ const IpcReadOptions& options;
+
+ DictionaryKind* kind;
Review comment:
This style, which uses a mutable pointer, follows the original code.
Here is an example. My guess is that this code needs to have a special state
`uninitialized`.
https://github.com/apache/arrow/blob/master/cpp/src/arrow/ipc/reader.cc#L716-L726
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
