pitrou commented on code in PR #14964:
URL: https://github.com/apache/arrow/pull/14964#discussion_r1094304818
##########
cpp/src/parquet/reader_test.cc:
##########
@@ -1059,4 +1060,165 @@ TEST(TestFileReader, TestOverflowInt16PageOrdinal) {
}
}
+struct PageIndexReaderParam {
+ PageIndexReaderParam(const std::vector<int32_t>& row_group_indices,
+ const std::vector<int32_t>& column_indices, bool
need_column_index,
+ bool need_offset_index)
+ : row_group_indices(row_group_indices),
+ column_indices(column_indices),
+ index_selection{need_column_index, need_offset_index} {}
Review Comment:
I don't think you need to write this constructor explicitly, aggregate
initialization will work automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
