viirya commented on code in PR #5194:
URL: https://github.com/apache/arrow-datafusion/pull/5194#discussion_r1097771337
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -418,6 +419,23 @@ macro_rules! binary_primitive_array_op {
}};
}
+/// Invoke a compute kernel on a pair of arrays
+/// The binary_primitive_array_op macro only evaluates for primitive types
+/// like integers and floats.
+macro_rules! binary_primitive_array_op_dyn {
+ ($LEFT:expr, $RIGHT:expr, $OP:ident) => {{
+ match $LEFT.data_type() {
+ DataType::Decimal128(_,_) => {
+ Ok(paste::expr! {[<$OP _decimal>]}(&$LEFT, &$RIGHT)?)
+ // Ok(Arc::new($OP(&$LEFT, &$RIGHT).map_err(|err|
DataFusionError::ArrowError(err))?))
Review Comment:
Aha, forgot to clean it up. I will remove it along with test coverage in
next commit. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
