viirya commented on code in PR #3673:
URL: https://github.com/apache/arrow-rs/pull/3673#discussion_r1099142154
##########
arrow-cast/src/cast.rs:
##########
@@ -168,7 +168,7 @@ pub fn can_cast_types(from_type: &DataType, to_type:
&DataType) -> bool {
| Time32(TimeUnit::Millisecond)
| Time64(TimeUnit::Microsecond)
| Time64(TimeUnit::Nanosecond)
- | Timestamp(TimeUnit::Nanosecond, None)
+ | Timestamp(TimeUnit::Nanosecond, _)
) => true,
Review Comment:
Since you have `*tz == Some("+00:00".to_owned())` as condition, it seems
also necessary to put it here. Otherwise there will be casting error because
`can_cast_types` reports it is supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
