lidavidm commented on code in PR #428: URL: https://github.com/apache/arrow-adbc/pull/428#discussion_r1100660768
########## adbc.h: ########## @@ -1183,7 +1204,11 @@ AdbcStatusCode AdbcStatementExecutePartitions(struct AdbcStatement* statement, /// driver. /// /// Although drivers may choose any name for this function, the -/// recommended name is "AdbcDriverInit". +/// recommended name is "AdbcDriverInit". If you use the recommended +/// name, then driver managers will be able to automatically find +/// the entrypoint function. Drivers may also expose the same function +/// under a unique symbol so that multiple drivers can be statically +/// linked into a single binary without any conflicts. Review Comment: I'd also say that these 'constraints' are really just a natural consequence of a few requirements. If you want to dynamically load drivers, you have to have some entrypoint; if you want to directly link to drivers, you have to define certain names; if you want both, then you have to expose both, and now if you want to statically link multiple drivers, something has to give. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
