ygf11 commented on code in PR #5156:
URL: https://github.com/apache/arrow-datafusion/pull/5156#discussion_r1102379162
##########
datafusion/core/src/physical_plan/joins/utils.rs:
##########
@@ -917,6 +917,23 @@ pub(crate) fn get_anti_indices(
.collect::<UInt32Array>()
}
+/// Get unmatched and deduplicated indices
+pub(crate) fn get_anti_u64_indices(
Review Comment:
Yes, we can merge these two.
Further more, `get_semi_indices` and `get_semi_u64_indices`(anti) can also
be merged to one function with generic.
I think it is relative to comment
https://github.com/apache/arrow-datafusion/pull/5156#discussion_r1100068420,
and @liukun4515 plans to refactor them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
