andygrove commented on code in PR #664:
URL: https://github.com/apache/arrow-ballista/pull/664#discussion_r1103633583
##########
ballista/scheduler/src/planner.rs:
##########
@@ -375,19 +373,19 @@ mod test {
/* Expected result:
ShuffleWriterExec: Some(Hash([Column { name: "l_returnflag", index: 0
}], 2))
- AggregateExec: mode=Partial, gby=[l_returnflag@1 as l_returnflag],
aggr=[SUM(l_extendedprice Multiply Int64(1))]
- CsvExec: source=Path(testdata/lineitem:
[testdata/lineitem/partition0.tbl,testdata/lineitem/partition1.tbl]),
has_header=false
+ AggregateExec: mode=Partial, gby=[l_returnflag@1 as l_returnflag],
aggr=[SUM(lineitem.l_extendedprice * Int64(1))]
+ CsvExec: files={2 groups:
[[ballista/scheduler/testdata/lineitem/partition1.tbl],
[ballista/scheduler/testdata/lineitem/partition0.tbl]]}, has_header=false,
limit=None, projection=[l_extendedprice, l_returnflag]
ShuffleWriterExec: None
- ProjectionExec: expr=[l_returnflag@0 as l_returnflag,
SUM(lineitem.l_extendedprice Multiply Int64(1))@1 as sum_disc_price]
- AggregateExec: mode=FinalPartitioned, gby=[l_returnflag@0 as
l_returnflag], aggr=[SUM(l_extendedprice Multiply Int64(1))]
- CoalesceBatchesExec: target_batch_size=4096
- UnresolvedShuffleExec
+ SortExec: [l_returnflag@0 ASC NULLS LAST]
+ ProjectionExec: expr=[l_returnflag@0 as l_returnflag,
SUM(lineitem.l_extendedprice * Int64(1))@1 as sum_disc_price]
+ AggregateExec: mode=FinalPartitioned, gby=[l_returnflag@0 as
l_returnflag], aggr=[SUM(lineitem.l_extendedprice * Int64(1))]
+ CoalesceBatchesExec: target_batch_size=8192
+ UnresolvedShuffleExec
ShuffleWriterExec: None
- SortExec: [l_returnflag@0 ASC]
- CoalescePartitionsExec
- UnresolvedShuffleExec
+ SortPreservingMergeExec: [l_returnflag@0 ASC NULLS LAST]
+ UnresolvedShuffleExec
Review Comment:
This query just go more efficient and sorts data in parallel now :rocket:
##########
ballista/scheduler/src/planner.rs:
##########
@@ -375,19 +373,19 @@ mod test {
/* Expected result:
ShuffleWriterExec: Some(Hash([Column { name: "l_returnflag", index: 0
}], 2))
- AggregateExec: mode=Partial, gby=[l_returnflag@1 as l_returnflag],
aggr=[SUM(l_extendedprice Multiply Int64(1))]
- CsvExec: source=Path(testdata/lineitem:
[testdata/lineitem/partition0.tbl,testdata/lineitem/partition1.tbl]),
has_header=false
+ AggregateExec: mode=Partial, gby=[l_returnflag@1 as l_returnflag],
aggr=[SUM(lineitem.l_extendedprice * Int64(1))]
+ CsvExec: files={2 groups:
[[ballista/scheduler/testdata/lineitem/partition1.tbl],
[ballista/scheduler/testdata/lineitem/partition0.tbl]]}, has_header=false,
limit=None, projection=[l_extendedprice, l_returnflag]
ShuffleWriterExec: None
- ProjectionExec: expr=[l_returnflag@0 as l_returnflag,
SUM(lineitem.l_extendedprice Multiply Int64(1))@1 as sum_disc_price]
- AggregateExec: mode=FinalPartitioned, gby=[l_returnflag@0 as
l_returnflag], aggr=[SUM(l_extendedprice Multiply Int64(1))]
- CoalesceBatchesExec: target_batch_size=4096
- UnresolvedShuffleExec
+ SortExec: [l_returnflag@0 ASC NULLS LAST]
+ ProjectionExec: expr=[l_returnflag@0 as l_returnflag,
SUM(lineitem.l_extendedprice * Int64(1))@1 as sum_disc_price]
+ AggregateExec: mode=FinalPartitioned, gby=[l_returnflag@0 as
l_returnflag], aggr=[SUM(lineitem.l_extendedprice * Int64(1))]
+ CoalesceBatchesExec: target_batch_size=8192
+ UnresolvedShuffleExec
ShuffleWriterExec: None
- SortExec: [l_returnflag@0 ASC]
- CoalescePartitionsExec
- UnresolvedShuffleExec
+ SortPreservingMergeExec: [l_returnflag@0 ASC NULLS LAST]
+ UnresolvedShuffleExec
Review Comment:
This query just got more efficient and sorts data in parallel now :rocket:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
