wjones127 commented on code in PR #428: URL: https://github.com/apache/arrow-adbc/pull/428#discussion_r1105135841
########## adbc.h: ########## @@ -1183,7 +1204,11 @@ AdbcStatusCode AdbcStatementExecutePartitions(struct AdbcStatement* statement, /// driver. /// /// Although drivers may choose any name for this function, the -/// recommended name is "AdbcDriverInit". +/// recommended name is "AdbcDriverInit". If you use the recommended +/// name, then driver managers will be able to automatically find +/// the entrypoint function. Drivers may also expose the same function +/// under a unique symbol so that multiple drivers can be statically +/// linked into a single binary without any conflicts. Review Comment: Ah then I must be misunderstanding some fundamental things here. I'll take a closer look at those. Up till now, I've understood ADBC as a C API that could be implemented by C/C++/Go/Rust and consumed by any language. I've haven't considered what it means to be a standard *within* a language. But I suppose this interacts with some of my open questions for how packaging should work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
