felipecrv commented on issue #33628: URL: https://github.com/apache/arrow/issues/33628#issuecomment-1428897933
@js8544 no need to have our own `enable_shared_from_this`. Let me try to be more clear: We should only be able to get a `shared_ptr<Scalar>` from a non-const `Scalar &` or `Scalar *`. We can only get a `shared_ptr<const Scalar>` from `const Scalar &` or `const Scalar *`. I understand that this utility was added because it's a hassle to have a mix of `shared_ptr<Scalar>` and `shared_ptr<const Scalar>` across the codebase, but if we want to be strict about `const` this is the way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
