lidavidm commented on code in PR #107:
URL: https://github.com/apache/arrow-nanoarrow/pull/107#discussion_r1105209442
##########
src/nanoarrow/schema_test.cc:
##########
@@ -139,6 +139,12 @@ TEST(SchemaTest, SchemaTestInitNestedMap) {
NANOARROW_OK);
ASSERT_EQ(ArrowSchemaSetType(schema.children[0]->children[1],
NANOARROW_TYPE_STRING),
NANOARROW_OK);
+ ASSERT_STREQ("entries", schema.children[0]->name);
+ ASSERT_STREQ("key", schema.children[0]->children[0]->name);
+ ASSERT_STREQ("value", schema.children[0]->children[1]->name);
+
+ ASSERT_FALSE(schema.children[0]->flags & ARROW_FLAG_NULLABLE);
+ ASSERT_FALSE(schema.children[0]->children[0]->flags & ARROW_FLAG_NULLABLE);
Review Comment:
ah, no particular reason other than habit.
IIRC, in Googletest:
- Assert aborts the test if it fails, Expect lets it continue
- Googletest goes `expected, actual`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
