js8544 commented on code in PR #34159:
URL: https://github.com/apache/arrow/pull/34159#discussion_r1105265178
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4796,6 +4835,11 @@ macro(build_awssdk)
"${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}s2n${CMAKE_STATIC_LIBRARY_SUFFIX}"
)
endif()
+ if(${_AWSSDK_LIB} STREQUAL "crypto" OR ${_AWSSDK_LIB} STREQUAL "ssl")
Review Comment:
changed to aws-lc
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4779,9 +4805,22 @@ macro(build_awssdk)
aws-c-event-stream
aws-c-io
aws-c-cal
- s2n-tls
aws-checksums
aws-c-common)
+
+ # aws-lc needs to be installed on a separate folder to hide from unintended
use
+ set(AWS_LC_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/aws_lc_ep-install")
+ set(AWS_LC_INCLUDE_DIR "${AWS_LC_PREFIX}/include")
+
+ if(UNIX AND NOT APPLE) # aws-lc and s2n-tls only needed on linux
+ file(MAKE_DIRECTORY ${AWS_LC_INCLUDE_DIR})
+ list(APPEND
+ _AWSSDK_LIBS
+ s2n-tls
+ crypto
+ ssl)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
