[GitHub] [arrow] AlenkaF commented on a diff in pull request #34178: GH-34023: [Docs] Version warning about viewing old docs doesn't work for versions >= 10

Tue, 14 Feb 2023 03:51:14 -0800 


AlenkaF commented on code in PR #34178:
URL: https://github.com/apache/arrow/pull/34178#discussion_r1105702757


##########
docs/source/_static/versionwarning.js:
##########
@@ -30,6 +30,7 @@
             // Path of the page
             var location_array = location.pathname.split('/');
             var versionPath = location_array[2];
+            var versionNumber = Number(versionPath.match(/^\d+/))

Review Comment:
   Yes, correct. It is the major part of the version format. Will rename 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to