tustvold commented on code in PR #3711:
URL: https://github.com/apache/arrow-rs/pull/3711#discussion_r1105960718
##########
arrow-array/src/array/primitive_array.rs:
##########
@@ -233,7 +233,8 @@ pub type Decimal256Array = PrimitiveArray<Decimal256Type>;
/// static-typed nature of rust types ([`ArrowNativeType`]) for all types that
implement [`ArrowNativeType`].
pub trait ArrowPrimitiveType: 'static {
/// Corresponding Rust native type for the primitive type.
- type Native: ArrowNativeType;
+ // FIXME: this may affect other code, is this correct?
+ type Native: ArrowNativeType + ArrowNativeTypeOp;
Review Comment:
```suggestion
type Native: ArrowNativeTypeOp;
```
`ArrowNativeType` is implied by `ArrowNativeTypeOp`.
I think this change is fine, but tagging @viirya who added
`ArrowNativeTypeOp` originally.
This will allow simplifying trait bounds in a number of other places, where
we currently have to add a `T::Native: ArrowNativeTypeOp` constraint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
