[GitHub] [arrow] icexelloss commented on a diff in pull request #34279: GH-34278: [C++] Expose schema in named table provider

[via GitHub]

icexelloss commented on code in PR #34279:
URL: https://github.com/apache/arrow/pull/34279#discussion_r1114415375


##########
cpp/src/arrow/engine/substrait/options.h:
##########
@@ -65,8 +65,8 @@ enum class ARROW_ENGINE_EXPORT ConversionStrictness {
   BEST_EFFORT,
 };
 
-using NamedTableProvider =
-    std::function<Result<compute::Declaration>(const 
std::vector<std::string>&)>;
+using NamedTableProvider = std::function<Result<compute::Declaration>(
+    const std::vector<std::string>&, const std::shared_ptr<Schema>)>;

Review Comment:
   Thanks sense. Will push another revision.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org