icexelloss commented on code in PR #34311:
URL: https://github.com/apache/arrow/pull/34311#discussion_r1117218417
##########
cpp/src/arrow/compute/exec.h:
##########
@@ -240,6 +246,8 @@ struct ARROW_EXPORT ExecBatch {
ExecBatch Slice(int64_t offset, int64_t length) const;
+ Result<ExecBatch> SelectValues(const std::vector<int>& ids) const;
Review Comment:
I'd imagine "extract" keys is needed for aggregation without the segmenter
change, how was that done before?
##########
cpp/src/arrow/compute/exec.h:
##########
@@ -240,6 +246,8 @@ struct ARROW_EXPORT ExecBatch {
ExecBatch Slice(int64_t offset, int64_t length) const;
+ Result<ExecBatch> SelectValues(const std::vector<int>& ids) const;
Review Comment:
I'd imagine "extract keys" is needed for aggregation without the segmenter
change, how was that done before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
