Dandandan commented on code in PR #5377:
URL: https://github.com/apache/arrow-datafusion/pull/5377#discussion_r1118543721
##########
datafusion/physical-expr/src/aggregate/count_distinct.rs:
##########
@@ -149,6 +149,43 @@ impl DistinctCountAccumulator {
self.update(&row_values)
})
}
+
+ // calculating the size approximately, taking first batch size * number of
batches
+ // approx_size has some inaccuracy for variable length values, like
strings.
+ fn approx_size(&self) -> usize {
Review Comment:
So we could change the name to e.g. `fixed_size`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
