eerhardt commented on a change in pull request #8694: URL: https://github.com/apache/arrow/pull/8694#discussion_r527973234
########## File path: csharp/src/Apache.Arrow.Flight/FlightDescriptor.cs ########## @@ -0,0 +1,105 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +using System; +using System.Collections.Generic; +using System.Linq; +using System.Text; +using Google.Protobuf; + +namespace Apache.Arrow.Flight +{ + public class FlightDescriptor + { + private readonly Protocol.FlightDescriptor _flightDescriptor; + + private FlightDescriptor(ByteString command) + { + _flightDescriptor = new Protocol.FlightDescriptor() + { + Cmd = command, + Type = Protocol.FlightDescriptor.Types.DescriptorType.Cmd + }; + } + + private FlightDescriptor(params string[] paths) + { + _flightDescriptor = new Protocol.FlightDescriptor() + { + Type = Protocol.FlightDescriptor.Types.DescriptorType.Path + }; + + foreach(var path in paths) + { + _flightDescriptor.Path.Add(path); + } + } + + + public static FlightDescriptor Command(byte[] command) + { + return new FlightDescriptor(ByteString.CopyFrom(command)); + } + + public static FlightDescriptor Command(string command) + { + return new FlightDescriptor(ByteString.CopyFromUtf8(command)); + } + + public static FlightDescriptor Path(params string[] paths) + { + return new FlightDescriptor(paths); + } + + + internal FlightDescriptor(Protocol.FlightDescriptor flightDescriptor) + { + if(flightDescriptor.Type != Protocol.FlightDescriptor.Types.DescriptorType.Cmd && flightDescriptor.Type != Protocol.FlightDescriptor.Types.DescriptorType.Path) + { + throw new NotSupportedException(); + } + _flightDescriptor = flightDescriptor; + } + + internal Protocol.FlightDescriptor ToProtocol() + { + return _flightDescriptor; + } + + public bool IsCommand => _flightDescriptor.Type == Protocol.FlightDescriptor.Types.DescriptorType.Cmd; Review comment: I think we should expose the `DescriptorType` as an enum instead of this `bool IsCommand` property. When callers are checking for a `PATH`, they would write `!IsCommand`. But this is an issue because: 1. If it isn't a Command, then what is it? It's not obvious from reading the code. 2. If there ever was a new kind of descriptor added, all existing code would be broken. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
