jorisvandenbossche commented on code in PR #34249:
URL: https://github.com/apache/arrow/pull/34249#discussion_r1137604961
##########
cpp/src/arrow/compute/exec/options.h:
##########
@@ -402,6 +402,14 @@ class ARROW_EXPORT OrderBySinkNodeOptions : public
SinkNodeOptions {
SortOptions sort_options;
};
+class ARROW_EXPORT OrderByNodeOptions : public ExecNodeOptions {
+ public:
+ static constexpr std::string_view kName = "order_by";
+ explicit OrderByNodeOptions(Ordering ordering) :
ordering(std::move(ordering)) {}
+
+ Ordering ordering;
Review Comment:
I think the Ordering certainly makes sense, and it's quite trivial to
convert the one into the other, I was just wondering for a consistent API if we
want to add a constructor version that accepts the SortOptions (or for
OrderBySinkNode to add a version that accepts Ordering)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
