zeroshade commented on code in PR #34558:
URL: https://github.com/apache/arrow/pull/34558#discussion_r1139260630
##########
go/arrow/csv/reader.go:
##########
@@ -755,6 +759,18 @@ func (r *Reader) parseList(field array.Builder, str
string) {
}
}
+func (r *Reader) parseBinaryDataType(field array.Builder, str string) {
+ if r.isNull(str) {
+ field.AppendNull()
+ return
+ }
+ decodedVal, err := base64.StdEncoding.DecodeString(str)
Review Comment:
Hmm. I'd suggest adding it to the `NewReader` godoc comment as that seems
most reasonable to me. To mention that a binary field expects to be base64
encoded with padding as per `base64.StdEncoding`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
