wgtmac commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1142834923
##########
cpp/src/parquet/encryption/dataset_encryption_config.h:
##########
@@ -0,0 +1,31 @@
+#pragma once
+
+#include "parquet/encryption/crypto_factory.h"
+#include "parquet/encryption/encryption.h"
+#include "parquet/encryption/kms_client.h"
+#include "arrow/dataset/type_fwd.h"
+
+namespace parquet {
+namespace encryption {
+
+struct PARQUET_EXPORT DatasetEncryptionConfiguration {
Review Comment:
Is it better not to expose dataset concepts within the parquet module? For
example the line 6 looks strange to me. `ARROW_PARQUET` can be built without
`ARROW_DATASET` enabled. We may add a translation layer to pass these config to
parquet writer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
