maartenbreddels commented on pull request #8755: URL: https://github.com/apache/arrow/pull/8755#issuecomment-733055953
I now also understand your point about readinto I think. I would be even better if the read that I changed would call .readinto right? That would make that codepath more efficient. So, I guess the simplest option is to have `Result<int64_t> PyReadableFile::Read(int64_t nbytes, void* out)` and `Result<std::shared_ptr<Buffer>> PyReadableFile::Read(int64_t nbytes)` call `.readinto` right? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org