r4ntix commented on code in PR #5732:
URL: https://github.com/apache/arrow-datafusion/pull/5732#discussion_r1148465297
##########
datafusion/core/Cargo.toml:
##########
@@ -85,7 +81,7 @@ lazy_static = { version = "^1.4.0" }
log = "^0.4"
num-traits = { version = "0.2", optional = true }
num_cpus = "1.13.0"
-object_store = "0.5.4"
+object_store = { version = "0.5.4", features = ["aws"] }
Review Comment:
Thinks for this feedback.
I think the question here is whether we enable access to cloud storage by
default for datafusion. If yes, it is the same whether to put the options in
datafusion or in object_store. If not, I can make this as an optional feature
for datafusion/core, and turn it on by default in the datafusion-cli.
Which do you think is better? happy to discuss this 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
