westonpace commented on code in PR #34691:
URL: https://github.com/apache/arrow/pull/34691#discussion_r1149639189
##########
cpp/src/arrow/record_batch.cc:
##########
@@ -198,14 +198,20 @@ Result<std::shared_ptr<RecordBatch>>
RecordBatch::MakeEmpty(
}
Result<std::shared_ptr<RecordBatch>> RecordBatch::FromStructArray(
- const std::shared_ptr<Array>& array) {
+ const std::shared_ptr<Array>& array, MemoryPool* memory_pool) {
Review Comment:
Good catch. Fortunately it seems we don't use this method too much. I
forwarded the parameter to two call sites in the JSON reader (although I think
we will always be zero-copy in those cases it doesn't hurt). There is one more
call site in Datum::MakeExecBatch but it was already missing a memory pool (and
implicitly using the default in other calls, e.g. cast) so I just left it as
is. I'm also not sure this code path is used anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
