kou commented on code in PR #34765:
URL: https://github.com/apache/arrow/pull/34765#discussion_r1153908580
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -115,6 +115,9 @@ elseif(ARROW_CPU_FLAG STREQUAL "aarch64")
if(ARROW_SIMD_LEVEL STREQUAL "DEFAULT")
set(ARROW_SIMD_LEVEL "NEON")
endif()
+ if(APPLE)
+ set(GTest_SOURCE "BUNDLED")
+ endif()
Review Comment:
The latter.
We can just wrap existing `GTestConfig.cmake` like we did in
`FindOpenSSLAlt.cmake`:
https://github.com/apache/arrow/blob/main/cpp/cmake_modules/FindOpenSSLAlt.cmake
> In this PR, We limit the scope to error out whenever
`INTERFACE_COMPILE_FEATURES` from GTest is lower than that? It will be
universal to all platforms and truly detect the issue at CMake configure time.
>
> Then in another PR/issue, we can discuss how to implement try_compile and
FindXXXAlt.cmake as it will need non trivial work.
It makes sense. Could you update the title of this pull request and open a
new issue for the follow-up action?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
