tustvold opened a new issue, #4025:
URL: https://github.com/apache/arrow-rs/issues/4025

   **Describe the bug**
   <!--
   A clear and concise description of what the bug is.
   -->
   
   Schema::contains states that it returns true if
   
   > self.metadata is a superset of other.metadata
   
   It then checks this with
   
   ```
   other.metadata().iter().all(|(k, v)| {
       match self.metadata().get(k) {
           Some(s) => s == v,
           None => false
       }
   })
   ```
   
   This will instead return true if `self.metadata` is a subset of 
`other.metadata`
   
   **To Reproduce**
   <!--
   Steps to reproduce the behavior:
   -->
   
   This appears to have been incorrect in the original implementation provided 
by @houqp in 
https://github.com/apache/arrow-rs/commit/a281c49194da4121386ab6211e42c0c1aa08008e.
 
   
   **Expected behavior**
   <!--
   A clear and concise description of what you expected to happen.
   -->
   
   **Additional context**
   <!--
   Add any other context about the problem here.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to