viirya commented on code in PR #5980:
URL: https://github.com/apache/arrow-datafusion/pull/5980#discussion_r1169177389
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -4801,18 +4878,18 @@ mod tests {
// subtract: decimal array subtract int32 array
let schema = Arc::new(Schema::new(vec![
- Field::new("b", DataType::Int32, true),
Field::new("a", DataType::Decimal128(10, 2), true),
Review Comment:
Previously the field order is incorrect. But as we did coerce type on both
side of the op anyway, so it still worked before. Now we don't coerce the
decimal field (which is wrongly bound to Int32Array) before into binary
expression, so wrong field causes an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
