drusso commented on a change in pull request #8836:
URL: https://github.com/apache/arrow/pull/8836#discussion_r536885271
##########
File path: rust/datafusion/src/physical_plan/udaf.rs
##########
@@ -64,6 +64,12 @@ impl Debug for AggregateUDF {
}
}
+impl PartialEq for AggregateUDF {
Review comment:
I wasn't sure if it was a suitable implementation, and Jorge's raised a
good reason why it's not. See thread below.
The changes in this pull request depend heavily on determining equivalency
of two expressions. For example, `rebase_expr()` and `find_exprs_in_expr()` use
`Vec::contains()` (which requires the contained items implement the
`PartialEq` trait).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
