comphead commented on code in PR #6188:
URL: https://github.com/apache/arrow-datafusion/pull/6188#discussion_r1182689135
##########
datafusion/core/src/physical_plan/joins/nested_loop_join.rs:
##########
@@ -375,13 +370,13 @@ struct NestedLoopJoinStream {
/// Join execution metrics
join_metrics: BuildProbeJoinMetrics,
/// Memory reservation for visited_left_side
- reservation: SharedMemoryReservation,
+ reservation: MemoryReservation,
}
fn build_join_indices(
left_index: usize,
batch: &RecordBatch,
Review Comment:
its out of the changes scope but probably we can rename too generic `batch`
into something else? like right_data, or probe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
