ming08108 commented on code in PR #4165:
URL: https://github.com/apache/arrow-rs/pull/4165#discussion_r1185638579
##########
arrow-ipc/src/reader.rs:
##########
@@ -1117,7 +1117,29 @@ impl<R: Read> StreamReader<R> {
reader: R,
projection: Option<Vec<usize>>,
) -> Result<Self, ArrowError> {
- let mut reader = BufReader::new(reader);
+ Self::try_new_unbuffered(BufReader::new(reader), projection)
+ }
+
+ /// Gets a reference to the underlying reader.
+ ///
+ /// It is inadvisable to directly read from the underlying reader.
+ pub fn get_ref(&self) -> &R {
Review Comment:
Updated so it is implemented for both. For consistency it always returns the
reader instead of the inner reader. This does make this a breaking change
however.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
