seddonm1 commented on a change in pull request #8866:
URL: https://github.com/apache/arrow/pull/8866#discussion_r539028012



##########
File path: rust/datafusion/src/datasource/datasource.rs
##########
@@ -24,6 +24,15 @@ use crate::arrow::datatypes::SchemaRef;
 use crate::error::Result;
 use crate::physical_plan::ExecutionPlan;
 
+/// The table statistics
+#[derive(Clone)]
+pub struct Statistics {
+    /// The number of table rows
+    pub num_rows: i64,

Review comment:
       My understanding is that because the parquet reader produces` i64` which 
(assuming above 0) is less than `u64` whereas a `usize` _may_ be smaller 
depending on compile target.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to