pitrou commented on PR #35149: URL: https://github.com/apache/arrow/pull/35149#issuecomment-1542439767
> I'm aware, but these don't exist/work for REE and Union arrays (and potentially new formats in the future) REE and Union are two different cases. For REE, it is better to iterate on runs, not logical values (exactly what you did for the "hash_count" kernel). > The `ifs` are inlined, so compiler might even be able to elide them, but these versions would guarantee that. I'm not sure we care about compile-time guarantees here, since it's just a performance concern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
