mapleFU commented on code in PR #35356: URL: https://github.com/apache/arrow/pull/35356#discussion_r1191234967
########## cpp/src/arrow/compute/dictionary_decode.cc: ########## @@ -0,0 +1,95 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "arrow/compute/dictionary_decode.h" + +#include <mutex> +#include <sstream> +#include <string> +#include <unordered_map> +#include <unordered_set> +#include <utility> +#include <vector> + +#include "arrow/compute/cast.h" +#include "arrow/compute/cast_internal.h" +#include "arrow/compute/exec.h" +#include "arrow/compute/function_internal.h" +#include "arrow/compute/kernel.h" +#include "arrow/compute/kernels/codegen_internal.h" +#include "arrow/compute/registry.h" +#include "arrow/util/logging.h" +#include "arrow/util/reflection_internal.h" + +namespace arrow { + +namespace compute { +namespace internal { + +namespace { + +const FunctionDoc dictionary_decode_doc{"Decodes a DictionaryArray to an Array", + "The Function will call cast to really decode.", + {"dictionary_array"}}; +class DictionaryDecodeMetaFunction : public MetaFunction { + public: + DictionaryDecodeMetaFunction() + : MetaFunction("dictionary_decode", Arity::Unary(), dictionary_decode_doc) {} + + Result<Datum> ExecuteImpl(const std::vector<Datum>& args, + const FunctionOptions* options, + ExecContext* ctx) const override { + if (args[0].type() == nullptr || args[0].type()->id() != Type::DICTIONARY) { + return Status::TypeError("Expected a DictonaryArray"); + } + + if (args[0].is_array()) { + ARROW_CHECK_NE(args[0].array()->dictionary, nullptr); + TypeHolder to_type(args[0].array()->dictionary->type); + CastOptions castOption = CastOptions::Safe(to_type); + return CallFunction("cast", args, &castOption, ctx); + } else if (args[0].is_chunked_array()) { + ARROW_CHECK_NE(args[0].chunked_array()->chunk(0), nullptr); + ARROW_CHECK_NE(args[0].chunked_array()->chunk(0)->data(), nullptr); + ARROW_CHECK_NE(args[0].chunked_array()->chunk(0)->data()->dictionary, nullptr); + TypeHolder to_type(args[0].chunked_array()->chunk(0)->data()->dictionary->type); + CastOptions castOption = CastOptions::Safe(to_type); + return CallFunction("cast", args, &castOption, ctx); + } else { + return Status::TypeError("Expected an Array or a Chunked Array"); + } + } +}; +} // namespace + +void RegisterDictionaryDecode(FunctionRegistry* registry) { + DCHECK_OK(registry->AddFunction(std::make_shared<DictionaryDecodeMetaFunction>())); +} + +} // namespace internal + +Result<Datum> DictionaryDecode(const Datum& value, ExecContext* ctx) { + return CallFunction("dictionary_decode", {value}, ctx); +} + +Result<std::shared_ptr<Array>> DictionaryDecode(const Array& value, ExecContext* ctx) { + ARROW_ASSIGN_OR_RAISE(Datum result, DictionaryDecode(Datum(value), ctx)); Review Comment: Should it just return an error result or raise exception? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
