tolleybot commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1191381664
##########
cpp/src/parquet/properties.h:
##########
@@ -513,16 +535,16 @@ class PARQUET_EXPORT WriterProperties {
return this;
}
- /// Disable decimal logical type with 1 <= precision <= 18 to be stored as
- /// integer physical type.
+ /// Disable decimal logical type with 1 <= precision <= 18 to be stored
+ /// as integer physical type.
///
/// Default disabled.
Builder* disable_store_decimal_as_integer() {
store_decimal_as_integer_ = false;
return this;
}
- /// Enable writing page index in general for all columns. Default disabled.
Review Comment:
Ok
##########
cpp/src/parquet/properties.h:
##########
@@ -582,8 +604,6 @@ class PARQUET_EXPORT WriterProperties {
get(item.first).set_dictionary_enabled(item.second);
for (const auto& item : statistics_enabled_)
get(item.first).set_statistics_enabled(item.second);
- for (const auto& item : page_index_enabled_)
- get(item.first).set_page_index_enabled(item.second);
Review Comment:
Got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
