kszucs commented on a change in pull request #8886:
URL: https://github.com/apache/arrow/pull/8886#discussion_r540102788
##########
File path: cpp/src/arrow/util/converter.h
##########
@@ -52,7 +52,15 @@ class Converter {
return Init(pool);
}
- virtual Status Append(InputType value) = 0;
+ virtual Status Append(InputType value) { return
Status::NotImplemented("Append"); }
Review comment:
@bkietz I think we should keep both `Append` and `Extend` since we wrap
the converter object with the `Chunker`, so if one implementation (like the
python one) choose to use `Append` then we don't need to subclass the chunker
class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
