WillAyd commented on code in PR #707:
URL: https://github.com/apache/arrow-adbc/pull/707#discussion_r1204788923
##########
c/driver/postgresql/statement.cc:
##########
@@ -683,6 +693,17 @@ AdbcStatusCode PostgresStatement::ExecuteQuery(struct
ArrowArrayStream* stream,
return na_res;
}
+ // If there are no output columns (e.g. a CREATE or UPDATE), then
+ // don't use COPY (which would fail anyways)
+ if (root_type.n_children() == 0) {
+ RAISE_ADBC(ExecuteUpdateQuery(rows_affected, error));
+ struct ArrowSchema schema;
+ std::memset(&schema, 0, sizeof(schema));
Review Comment:
Is there any consideration to using memset versus `{0}` during assignment? I
think I've seen the latter more often in the code base
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
