Dandandan commented on pull request #8901: URL: https://github.com/apache/arrow/pull/8901#issuecomment-743827047
Very cool proposal. Will take some time soon to read it in detail. I think currently there is a lot of code violating what is proposed, so that's clearly needed 👍 I think it also makes sense to keep track of the amount of `unsafe` that is used, and try to reduce it as much as possible by introducing safe APIs that are as performant. An example might be: introducing a safe iterator to avoid bounds checking. Also I think the unsafe code can /should be more tested, e.g. by having more `debug_asserts` etc. checking for invariants and checking for undefined behavior in the CI. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
