mustafasrepo commented on code in PR #6482:
URL: https://github.com/apache/arrow-datafusion/pull/6482#discussion_r1210007671
##########
datafusion/physical-expr/src/utils.rs:
##########
@@ -679,6 +679,19 @@ pub fn reassign_predicate_columns(
})
}
+/// Reverses the ORDER BY expression, which is useful during equivalent window
+/// expression construction. For instance, 'ORDER BY a ASC, NULLS LAST' turns
into
+/// 'ORDER BY a DESC, NULLS FIRST'.
+pub fn reverse_order_bys(order_bys: &[PhysicalSortExpr]) ->
Vec<PhysicalSortExpr> {
Review Comment:
`reverse_order_bys` is moved under `sort_expr.rs` to be able to use it in
`src/physical_plan/aggregates/mod.rs`. With this change scope of the function
is increased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
