candiduslynx opened a new pull request, #35823:
URL: https://github.com/apache/arrow/pull/35823

   ### Rationale for this change
   
   The key order in Go maps is undefined.
   This PR extends `array.ApproxEqual` by allowing map keys to be in different 
order.
   
   ### What changes are included in this PR?
   
   New helper functions:
   * `array.arrayApproxEqualMap` that is now used instead of 
`array.arrayApproxEqualList` for map comparison
   * `array.arrayApproxEqualSingleMapEntry` that checks if the single map entry 
we have matches to the other one without having keys sorted the same way
   
   ### Are these changes tested?
   
   https://github.com/cloudquery/cloudquery/pull/11078
   
   ### Are there any user-facing changes?
   
   Now the maps with different key order but the approximately same values/keys 
will pass `array.ApproxEqual`
   
   <!--
   If there are any breaking changes to public APIs, please uncomment the line 
below and explain which changes are breaking.
   -->
   <!-- **This PR includes breaking changes to public APIs.** -->
   
   <!--
   Please uncomment the line below (and provide explanation) if the changes fix 
either (a) a security vulnerability, (b) a bug that caused incorrect or invalid 
data to be produced, or (c) a bug that causes a crash (even when the API 
contract is upheld). We use this to highlight fixes to issues that may affect 
users without their knowledge. For this reason, fixing bugs that cause errors 
don't count, since those are usually obvious.
   -->
   <!-- **This PR contains a "Critical Fix".** -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to