[GitHub] [arrow] kou commented on a diff in pull request #35827: GH-35676: [MATLAB] Add an `InferNulls` name-value pair for controlling null value inference during construction of `arrow.array.Array`

[via GitHub]

kou commented on code in PR #35827:
URL: https://github.com/apache/arrow/pull/35827#discussion_r1210796082


##########
matlab/src/matlab/+arrow/+args/parseValidElements.m:
##########
@@ -0,0 +1,28 @@
+function validElements = parseValidElements(data, detectNulls, 
nullDetectionFcn)
+    % Returns a logical vector of the validElements in data. If inferNulls

Review Comment:
   ```suggestion
       % Returns a logical vector of the validElements in data. If detectNulls
   ```
   
   A caller uses `inferNulls`. So we may want to rename `detectNulls` in this 
function to `inferNulls`...



##########
matlab/src/matlab/+arrow/+args/parseValidElements.m:
##########
@@ -0,0 +1,28 @@
+function validElements = parseValidElements(data, detectNulls, 
nullDetectionFcn)
+    % Returns a logical vector of the validElements in data. If inferNulls
+    % is true, calls ismissing on data to determine which elements are 
+    % null.
+
+    % Licensed to the Apache Software Foundation (ASF) under one or more
+    % contributor license agreements.  See the NOTICE file distributed with
+    % this work for additional information regarding copyright ownership.
+    % The ASF licenses this file to you under the Apache License, Version
+    % 2.0 (the "License"); you may not use this file except in compliance
+    % with the License.  You may obtain a copy of the License at
+    %
+    %   http://www.apache.org/licenses/LICENSE-2.0
+    %
+    % Unless required by applicable law or agreed to in writing, software
+    % distributed under the License is distributed on an "AS IS" BASIS,
+    % WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+    % implied.  See the License for the specific language governing
+    % permissions and limitations under the License.

Review Comment:
   Can we move this license header to the top level?
   
   ```matlab
   % Licensed to the Apache ...
   % ...
   
   function validElements = ...
   ```



##########
matlab/src/matlab/+arrow/+args/parseValidElements.m:
##########
@@ -0,0 +1,28 @@
+function validElements = parseValidElements(data, detectNulls, 
nullDetectionFcn)

Review Comment:
   It seems that `nullDetectionFcn` isn't used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org