viirya commented on code in PR #4318:
URL: https://github.com/apache/arrow-rs/pull/4318#discussion_r1211876162
##########
arrow-buffer/src/bigint.rs:
##########
@@ -429,12 +426,12 @@ impl i256 {
/// Division operation, returns (quotient, remainder).
/// This basically implements [Long division]:
`<https://en.wikipedia.org/wiki/Division_algorithm>`
#[inline]
- fn div_rem(self, other: Self) -> Result<(Self, Self), I256Error> {
+ fn div_rem(self, other: Self) -> Result<(Self, Self), DivRemError> {
if other == Self::ZERO {
- return Err(I256Error::DivideByZero);
+ return Err(DivRemError::DivideByZero);
}
if other == Self::MINUS_ONE && self == Self::MIN {
- return Err(I256Error::DivideOverflow);
+ return Err(DivRemError::DivideOverflow);
}
Review Comment:
Oh, okay, we don't need new error enum as this is internal. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
