roeap commented on code in PR #4296:
URL: https://github.com/apache/arrow-rs/pull/4296#discussion_r1212714664
##########
arrow-flight/examples/flight_sql_server.rs:
##########
@@ -363,26 +399,88 @@ impl FlightSqlService for FlightSqlServiceImpl {
async fn do_get_catalogs(
&self,
- _query: CommandGetCatalogs,
+ query: CommandGetCatalogs,
_request: Request<Ticket>,
) -> Result<Response<<Self as FlightService>::DoGetStream>, Status> {
- Err(Status::unimplemented("do_get_catalogs not implemented"))
+ let catalog_names = TABLES
+ .iter()
+ .map(|full_name|
full_name.split('.').collect::<Vec<_>>()[0].to_string())
+ .collect::<HashSet<_>>();
+ let mut builder = query.into_builder();
+ for catalog_name in catalog_names {
+ builder.append(catalog_name);
+ }
+ let batch = builder.build();
+ let stream = FlightDataEncoderBuilder::new()
+ .with_schema(Arc::new(get_catalogs_schema().clone()))
+ .build(futures::stream::once(async { batch }))
+ .map_err(Status::from);
+ Ok(Response::new(Box::pin(stream)))
}
async fn do_get_schemas(
&self,
- _query: CommandGetDbSchemas,
+ query: CommandGetDbSchemas,
_request: Request<Ticket>,
) -> Result<Response<<Self as FlightService>::DoGetStream>, Status> {
- Err(Status::unimplemented("do_get_schemas not implemented"))
+ let schemas = TABLES
+ .iter()
+ .map(|full_name| {
+ let parts = full_name.split('.').collect::<Vec<_>>();
+ (parts[0].to_string(), parts[1].to_string())
+ })
+ .collect::<HashSet<_>>();
+
+ let mut builder = query.into_builder();
+ for (catalog_name, schema_name) in schemas {
+ builder.append(catalog_name, schema_name);
+ }
+
+ let batch = builder.build();
+ let stream = FlightDataEncoderBuilder::new()
+ .with_schema(get_db_schemas_schema())
+ .build(futures::stream::once(async { batch }))
+ .map_err(Status::from);
Review Comment:
Seeing that this code is also always the same, should we add a method
`build_stream`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
