candiduslynx opened a new pull request, #35872: URL: https://github.com/apache/arrow/pull/35872
### Rationale for this change When comparing `array.Struct` values with `array.ApproxEqual` the validity bitmap of the struct itself should take precedence: > When reading the struct array the parent validity bitmap takes priority. This follows a brief discussion from #35851. ### What changes are included in this PR? `array.arrayApproxEqualStruct` will check the fields data only if the struct elem is valid. ### Are these changes tested? `pqarrow` tests are updated accordingly (no special treatment for structs, just `array.ApproxEqual` ### Are there any user-facing changes? `array.ApproxEqual` behavior changed to match the docs about validity bitmap precedence. <!-- If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking. --> <!-- **This PR includes breaking changes to public APIs.** --> <!-- Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious. --> <!-- **This PR contains a "Critical Fix".** --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
